Stack Exchange
log in sign up chat discuss faq users badges

Area 51 » Technology

definition commitment beta
147
followers

Code Review

Launched Q&A site for feedback on projects you're working on, by sharing your code with fellow programmers and getting extensive feedback/review of best practices, design pattern usage, application UI, security, etc.

Announcements

2  
Should this proposal be called "Beta Testers" or "Code Review?" I think of beta testers as customers who know the program might be incomplete or contain errors, but who want to try it anyway and offer feedback and bug reports. Beta testers seldom see actual code, and are not programmers, whereas a code review involves reviewing code with other programmers. – Robert Harvey Jul 6 '10 at 14:54
3  
I'm confused, is it a Q&A site? Or is it a Beta Tester recruitment site? – rlb.usa Jul 6 '10 at 17:03
4  
Apoloigse, "Code Review" would be a more descriptive title to what this proposal is concerning, the basic point of a this proposal is to be able to detailed reviews on your Design Patter, Application UI, Security etc. – RobertPitt Jul 7 '10 at 8:14
show 16 more announcements

38 Example Questions (11 closed)

active newest votes
up vote 26 down vote
Here is my source code for the new library I am writing. Does this API look sufficiently well designed?
added by Larry Smithmier Jul 6 '10 at 16:36
link
That's a good example of what should be the site about. you give the code of something you're working on and the rest of the community verifies it. – Victor Gil Nov 23 '10 at 17:54
Agree with on-topic, though it does seem a wee bit broad in scope. – Zayne S Halsall Dec 12 '10 at 12:51
Would it be better if it were stated: Here is my source code for the new library I am writing. Does the [Factory] portion API look sufficiently well designed? – Larry Smithmier Dec 13 '10 at 1:46
up vote 22 down vote
Is this shuffling algorithm OK?
added by PleaseStand Dec 5 '10 at 5:00
link
2  
An example of such a flawed algorithm: cigital.com/papers/download/… – PleaseStand Dec 5 '10 at 5:01
@idealmachine: i lol'd +1 – Stingervz Dec 17 '10 at 7:22
Seems like this would be a good question for stackoverflow... why would this site be better for this question? – Beth Whitezel Dec 24 '10 at 6:35
up vote 21 down vote
How can I improve my variable naming conventions in the following piece of code "code sample here"
added by Wes Aug 20 '10 at 21:50
link
up vote 20 down vote
Does my [website|app|library] work intuitively? What is confusing?
added by Aiden Bell Jul 6 '10 at 19:54
link
up vote 20 down vote
Is there a more modern way to achieve the effect I'm doing with this piece of code "insert sample here"
added by Wes Aug 20 '10 at 21:51
link
up vote 14 down vote
Please check the following code and see if its memory usage is efficent.
added by Wes Aug 20 '10 at 21:50
link
1  
I am not clear on why this is off-topic? – Josh Nov 22 '10 at 20:08
Neither am I to be honest. – Wes Nov 22 '10 at 20:16
If you can't check this on your own, I don't think begging other people on the internet to do it for you will really get you anywhere. – Sneakyness Dec 12 '10 at 3:45
I don't like the way it is phrased. It would be better as "Are there any memory leaks in this code?" – Hosam Aly Dec 21 '10 at 14:39
up vote 9 down vote
How do you code review at work? Peer review (after the event), extreme programming (real time), automated or something else?
added by Wikis Jul 12 '10 at 21:40
link
1  
I think this question would be best suited to programmers.stackexchange – Hosam Aly Dec 21 '10 at 14:38
@Hosam Aly - if that's the case doesn't that then apply to this whole proposal? – Wikis Dec 22 '10 at 9:46
@Mark Robinson If they are intending this site to support things like open source projects then it would make sense to do it here. In that case you may end up with a tag that is actually for a paticular project. – Beth Whitezel Dec 24 '10 at 6:39
up vote 9 down vote
Am I using decorators excessively here for method logging purposes? What better solutions could I explore?
added by Gordon Gustafson Dec 16 '10 at 16:03
link
up vote 9 down vote
Is this program easy to read and understand?
added by david4dev Dec 20 '10 at 23:53
link
up vote 7 down vote
Are there any security vulnerabilities in this function?
added by david4dev Dec 20 '10 at 23:55
link
up vote 7 down vote
How could I use polymorphism to get rid of this long nested if?
added by Anthony Pegram Dec 21 '10 at 18:22
link
up vote 6 down vote
Designing a generic solution: how would you abstract this algorithm?
added by Julio Guerra Nov 23 '10 at 0:56
link
up vote 6 down vote
How can I improve the performance of the following code?
added by david4dev Dec 20 '10 at 23:52
link
up vote 5 down vote
I need to build a logger module for my application - Here is the class diagram for what I'm designing, is this design good?
added by Narayana Dec 21 '10 at 2:11
link
up vote 5 down vote
"is my commenting for this class/method clear?"
added by Visionary Software Solutions Dec 22 '10 at 4:51
link
up vote 4 down vote
Should we always rely on design patterns? Example with the Visitor design pattern.
added by Julio Guerra Nov 23 '10 at 0:44
link
why isn't this a stackoverflow or programmers question? – Beth Whitezel Dec 24 '10 at 6:36
up vote 4 down vote
Is this 3 nested for-loops with a continue that breaks in a special case a good way of building an object?
added by Visionary Software Solutions Dec 22 '10 at 4:51
link
up vote 3 down vote
Is this a good strategy for Repository.Update() from an MVC Controller?
added by AJ Johnson Dec 16 '10 at 16:51
link
up vote 3 down vote
What do you think of my source code directory layout?
added by david4dev Dec 20 '10 at 23:54
link
I think it's good, the directory structure is important since it's part of the architecture – Hoàng Long Dec 24 '10 at 1:57
up vote 3 down vote
Am I abusing HTML tables in my website layout? This is the link to it: http://www.mywebsitehere.com/
added by DarkLightA Dec 22 '10 at 10:21
link
up vote 2 down vote
My new [website] is available at [url]. Email me for a login at [email]. Specifically looking for feedback on [x]. [closed]
added by Larry Smithmier Jul 6 '10 at 16:35
link

closed as off topic by Jeff, Asa Ayers, Wes, Georges Duplessy, Edgar Nov 23 '10 at 0:50

This question does not relate to the topic of the proposal.
It was closed as part of an automated migration of off-topic to close votes on September 29, 2011.

1  
Code or Screenshots would make this question on-topic. Merely giving a url without context, or introducing an extra step to (email me for credentials) should be frowned upon. – Kyle Trauberman Dec 20 '10 at 22:49
Updated per comment. I believe I retained the original feel but addressed the concerns Kyle raised. – Larry Smithmier Dec 22 '10 at 0:02
on-topic :) SPACE – DarkLightA Dec 22 '10 at 10:23
I also think this might be on-topic – Felix Dombek Dec 24 '10 at 2:19
Taking it back to the original off topic example. Sorry, I was trying to make it on topic for some reason. – Larry Smithmier Dec 26 '10 at 2:53
up vote 2 down vote
Trying to (correctly) thread my event handler system.
added by Julio Guerra Nov 23 '10 at 0:50
link
More of a SO question – Hailwood Dec 7 '10 at 9:19
up vote 1 down vote
Which C++ parallelism library would you use to [program purpose]? [closed]
added by Julio Guerra Nov 23 '10 at 0:53
link

closed as off topic by Zayne S Halsall, The Josenator, Stefan H, david4dev, Martin Dec 27 '10 at 0:41

This question does not relate to the topic of the proposal.
It was closed as part of an automated migration of off-topic to close votes on September 29, 2011.
up vote 0 down vote
Someone defaced our website, and from reviewing the logs, I think they might've come in from this PHP script [link to code]. Does it look vulnerable? [closed]
added by Joe Jul 6 '10 at 15:31
link

closed as off topic by Aiden Bell, Jeff, Mr_Qqn, Larry Smithmier, Asa Ayers Oct 1 '10 at 17:26

This question does not relate to the topic of the proposal.
It was closed as part of an automated migration of off-topic to close votes on September 29, 2011.

Off topic i'd say. More a SO question than a 'test and feedback' question – Aiden Bell Jul 6 '10 at 19:52
up vote 0 down vote
What's the difference between adapters and decorators? [closed]
added by Gordon Gustafson Dec 16 '10 at 20:23
link

closed as off topic by Stingervz, The Josenator, Felix Dombek, Kyle Trauberman, Xavier Nodet Dec 21 '10 at 22:22

This question does not relate to the topic of the proposal.
It was closed as part of an automated migration of off-topic to close votes on September 29, 2011.

Better for StackOverflow. – Kyle Trauberman Dec 20 '10 at 22:50
up vote 0 down vote
What's a better indentation choice in python, tabs or spaces? [closed]
added by Gordon Gustafson Dec 16 '10 at 20:26
link

closed as off topic by Stingervz, The Josenator, Klaim, Tommy Persson, Xavier Nodet Dec 21 '10 at 22:24

This question does not relate to the topic of the proposal.
It was closed as part of an automated migration of off-topic to close votes on September 29, 2011.
up vote 0 down vote
Does firefox 4 beta look promising enough that I should upgrade right away? [closed]
added by Gordon Gustafson Dec 20 '10 at 13:59
link

closed as off topic by Kyle Trauberman, Visionary Software Solutions, jan.vdbergh, the_drow, nocley Dec 22 '10 at 15:53

This question does not relate to the topic of the proposal.
It was closed as part of an automated migration of off-topic to close votes on September 29, 2011.
up vote 0 down vote
This code works on [platform A]; can you test it on [platform B] for me? [closed]
added by david4dev Dec 20 '10 at 23:56
link

closed as off topic by Jake, Tommy Persson, Visionary Software Solutions, jan.vdbergh, DarkLightA Dec 22 '10 at 10:22

This question does not relate to the topic of the proposal.
It was closed as part of an automated migration of off-topic to close votes on September 29, 2011.
up vote 0 down vote
Does this extremely generic and polymorphic inheritance hierarchy have issues?
added by Visionary Software Solutions Dec 22 '10 at 4:52
link
up vote 0 down vote
[Given the framework, language and general description], is it easy to understand this code as a fresher?
added by Hoàng Long Dec 24 '10 at 1:59
link
up vote 0 down vote
how can i refactor this code?
added by Saif al Harthi Dec 27 '10 at 2:18
link
up vote -1 down vote
My tutor says that I need to implement a fast sort on this data structure. CODE PLEASE [closed]
added by Wes Nov 4 '10 at 14:12
link

closed as off topic by AviD, jcolebrand, Josh, Georges Duplessy, Edgar Nov 23 '10 at 0:50

This question does not relate to the topic of the proposal.
It was closed as part of an automated migration of off-topic to close votes on September 29, 2011.
up vote -1 down vote
If you could change one thing about jQuery, what would it be? [closed]
added by Gordon Gustafson Dec 16 '10 at 20:24
link

closed as off topic by Stingervz, Felix Dombek, Kyle Trauberman, Anthony Pegram, Xavier Nodet Dec 21 '10 at 22:25

This question does not relate to the topic of the proposal.
It was closed as part of an automated migration of off-topic to close votes on September 29, 2011.
up vote -2 down vote
Does [my homepage | Splash | tagline] communicate what my [software|app] *really* does when you use it? [closed]
added by Aiden Bell Jul 6 '10 at 19:54
link

closed as off topic by Jeff, Mr_Qqn, Wes, Larry Smithmier, Asa Ayers Oct 1 '10 at 17:26

This question does not relate to the topic of the proposal.
It was closed as part of an automated migration of off-topic to close votes on September 29, 2011.
up vote -3 down vote
I Have built a new site and was hoping to get feedback on my Database Abstraction for security purposes ?
added by RobertPitt Jul 6 '10 at 12:56
link
1  
too broad I would recon. – Aiden Bell Jul 6 '10 at 19:52
I think if a modest amount of sourcecode is attached, this is exactly the kind of stuff that people could expect help on from this site ... – Felix Dombek Dec 20 '10 at 9:04
up vote -3 down vote
I use FxCop and StyleCop for code review automation, is there any other tools available out there which does a similar function ?
added by Binoj Antony Jul 10 '10 at 5:20
link
4  
Wouldn't that question belong more on stack overflow? – Wes Aug 20 '10 at 21:57
I agree @Wes, and it's not a clear and good example for this proposal... – Josh Nov 22 '10 at 20:09
Agree that this is more of an identification of tools question than a code-review/design review question. – Visionary Software Solutions Dec 22 '10 at 4:57
up vote -3 down vote
Project X UML: any advice ?
added by Julio Guerra Nov 23 '10 at 0:47
link
If a diagram was included, I think this would be the perfect type of question. Though it would have to be a small class diagram/activity/sequence type of diagram, and it would help to narrow the problem from "any advice?" to something more specific (i.e. "How does this modeling of Users and Profiles compare in terms of efficiency and scalability with other approaches?") – Visionary Software Solutions Dec 22 '10 at 5:01
up vote -4 down vote
Why are closures a bad idea? [closed]
added by Wes Nov 4 '10 at 14:11
link

closed as off topic by jcolebrand, Kaji, Zayne S Halsall, albert green, doppelgreener Dec 16 '10 at 2:30

This question does not relate to the topic of the proposal.
It was closed as part of an automated migration of off-topic to close votes on September 29, 2011.

I'm hoping this is off topic – Wes Nov 4 '10 at 14:11
I can't decide between OT and NAGE. Do we really expect this sort of thing to show up? – Pops Nov 22 '10 at 20:06
2  
I think it's too subjective and argumentative for any SE site. – Josh Nov 22 '10 at 20:07
Possibly I was just trying to come up with an example question – Wes Nov 22 '10 at 20:13
4  
@Josh: It would be perfect on Programmers.SE, with an edit: "Are closures a bad idea?". The presumption is left for the question body where the asker can say "I have read that closures are X etc." – doppelgreener Dec 16 '10 at 2:32